Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44444: Add parse_timedelta function to parse durations #247

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

rra
Copy link
Member

@rra rra commented May 21, 2024

Add a new safir.datetime.parse_timedelta function that parses a human-friendly syntax for time durations into a datetime.timedelta. The syntax was taken from semaphore and is now also used in the configuration parser for Gafaelfawr.

Add a new safir.datetime.parse_timedelta function that parses a
human-friendly syntax for time durations into a datetime.timedelta.
The syntax was taken from semaphore and is now also used in the
configuration parser for Gafaelfawr.
@rra rra requested a review from jonathansick May 21, 2024 22:29
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/user-guide/datetime.rst Outdated Show resolved Hide resolved
Rather than only showing the bare field_validator function, put it
in a sample model for a better example.
@rra rra enabled auto-merge May 22, 2024 15:57
@rra rra disabled auto-merge May 22, 2024 15:57
@rra rra enabled auto-merge May 22, 2024 15:57
@rra rra merged commit f68a6e0 into main May 22, 2024
5 checks passed
@rra rra deleted the tickets/DM-44444 branch May 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants